Commenting on PRs

Please refrain from using the general Add a comment box in GitHub PRs when leaving a comment or performing a review.

Comments that are left like this are not threaded, which makes it difficult to keep track of multiple conversations.

Comments that are instead left in the manner described below will have a built-in reply box to keep conversations in a single thread. These comments can also be marked as resolved afterwards, so that discussion can be tracked more easily.

Commenting

To start a threaded comment, you should leave all comments under the Files changed tab in a PR.

To leave a general comment on a PR, click the comment icon to the right of a file:

If the PR has multiple files changed, comment on the primary or most relevant file changed, or comment on the first file if you can't decide.

To leave a comment on a specific line of a PR, hover over the line where you'd like to add a comment, and click the blue comment icon:

(Optionally, you can add a comment on multiple lines. You can click the line number of the first line you want to comment on and drag down to select a range of lines, then click the blue comment icon on the last line you want to comment on. Alternatively, you can click the blue comment icon next to the first line you want to comment on, then drag down to the last line you want to comment on.)

Then, type your comment and click Add single comment.

Reviewing

When performing a review, follow the same steps as above, but click Start a review (and subsequently, Add a review comment) instead of Add single comment.

Then, click the green Finish your review button at the top of the page.

Do not leave any discussion comments in the Leave a comment box in the review finalization pop-up. You can leave it blank, or leave a short note if it will not require any follow-up. To comment on something that will require further discussion, add a comment on a file as described above instead.

Then, click Submit review.

Estás visitando la copia en Español de Privacy Guides, traducida por nuestro fantástico equipo traductor en Crowdin. ¡Si encuentras un error o ves algunas secciones sin traducir en esta página, por favor considera ayudar! Visita Crowdin

You're viewing the Spanish copy of Privacy Guides, translated by our fantastic language team on Crowdin. If you notice an error, or see any untranslated sections on this page, please consider helping out!